Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rounded corner box characters don't seem to be rendered correctly #3894

Closed
npezza93 opened this issue Jul 10, 2022 · 1 comment · Fixed by #3895
Closed

Rounded corner box characters don't seem to be rendered correctly #3894

npezza93 opened this issue Jul 10, 2022 · 1 comment · Fixed by #3895
Assignees
Milestone

Comments

@npezza93
Copy link
Contributor

Rounded corner characters are rendered at kind of an angle and differently than the default macOS terminal or rendered in the browser. I have tried Fira code, jet brains mono, and sf mono fonts and all render the same way. I have also tried all variations of turning on and off canvas, webgl, and ligatures and all render the same way.

Details

  • Browser and browser version: electron 19
  • OS version: macOS Monterey
  • xterm.js version: 4.18 and 4.19

Steps to reproduce

  1. echo "╭─╮\n\r│ │\n\r╰─╯\n\r"

xterm:
image

default macOS terminal:
image

@Tyriar
Copy link
Member

Tyriar commented Jul 10, 2022

I agree it would look better like you suggest. You can change to the font rendering by setting customGlyphs to false, they won't be properly aligned then though.

@Tyriar Tyriar self-assigned this Jul 10, 2022
@Tyriar Tyriar added this to the 4.20.0 milestone Jul 10, 2022
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Jul 10, 2022
@Tyriar Tyriar modified the milestones: 4.20.0, 5.0.0 Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants