Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demo isn't running on master #3585

Closed
Tyriar opened this issue Dec 22, 2021 · 1 comment · Fixed by #3586
Closed

Demo isn't running on master #3585

Tyriar opened this issue Dec 22, 2021 · 1 comment · Fixed by #3586
Assignees
@Tyriar
Labels
important type/bug Something is misbehaving
Milestone
4.16.0

Comments

@Tyriar
Copy link
Member

Tyriar commented Dec 22, 2021

image
@Tyriar Tyriar added type/bug Something is misbehaving important labels Dec 22, 2021
@Tyriar Tyriar added this to the 4.16.0 milestone Dec 22, 2021
@Tyriar Tyriar self-assigned this Dec 22, 2021
@Tyriar
Copy link
Member Author

Tyriar commented Dec 22, 2021

Root cause because Object.keys doesn't work with define prop

xterm.js/demo/client.ts

Line 296 in 6c8d801

const options = Object.keys(term.options);

Tyriar added a commit to Tyriar/xterm.js that referenced this issue Dec 22, 2021
@Tyriar
Fix demo
13b8c78 
Fixes xtermjs#3585
@Tyriar Tyriar mentioned this issue Dec 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
important type/bug Something is misbehaving
Projects
None yet
Milestone
4.16.0
Development

Successfully merging a pull request may close this issue.

Fix demo Tyriar/xterm.js
1 participant
@Tyriar