Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webgl dispose can throw #3348

Closed
Tyriar opened this issue May 17, 2021 · 0 comments
Closed

Webgl dispose can throw #3348

Tyriar opened this issue May 17, 2021 · 0 comments
Assignees
@meganrogge
Labels
area/addon/webgl type/bug Something is misbehaving
Milestone
4.14.0

Comments

@Tyriar
Copy link
Member

Tyriar commented May 17, 2021

Rough repro:

  1. Create terminal and open
  2. Load addon
  3. Detach element from DOM
  4. Dispose addon

This line throws

xterm.js/addons/xterm-addon-webgl/src/WebglRenderer.ts

Line 111 in a385ab0

this._core.screenElement!.removeChild(this._canvas);

Ran into this when implementing unsplit which will reparent the terminal element. microsoft/vscode#121278
@Tyriar Tyriar added type/bug Something is misbehaving area/addon/webgl labels May 17, 2021
@Tyriar Tyriar added this to the 4.13.0 milestone May 17, 2021
@Tyriar Tyriar self-assigned this May 17, 2021
@Tyriar Tyriar modified the milestones: 4.13.0, 4.14.0 Jun 24, 2021
@Tyriar Tyriar assigned meganrogge and unassigned Tyriar Sep 1, 2021
@Tyriar Tyriar closed this as completed in 3c8f600 Sep 1, 2021
Tyriar added a commit that referenced this issue Sep 1, 2021
@Tyriar
Merge pull request #3454 from meganrogge/master
504a8eb 
fix #3348
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meganrogge meganrogge

Labels
area/addon/webgl type/bug Something is misbehaving
Projects
None yet
Milestone
4.14.0
Development

No branches or pull requests
2 participants
@Tyriar @meganrogge