-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hover callback for LinkProviders #3056
Comments
👍 PR welcome to add the hover callback to the web link provider, it needs to get added to the result Lines 1146 to 1153 in 566fad4
|
@Tyriar this would be a quick and dirty way of passing the callbacks through, what do you think https://github.com/Coding-Kiwi/xterm.js/commit/8d7958c3df3b6a00a3623cf591ae67e186507711 |
@Coding-Kiwi something like that is what I was thinking, decorating the result of const links = LinkComputer.computeLink(y, this._regex, this._terminal, this._handler);
callback(addCallbacks(links, this._options.tooltipCallback, this._options.leaveCallback); Want to iterate on it in a PR? |
The LinkMatchers are eventually removed, right?
If you pass
_useLinkProvider
to the xterm-web-links-addon, there is currently no way to get a hover callback to show a tooltip.I would like to switch to the LinkProvider but I also want to show a tooltip when hovering a link
The text was updated successfully, but these errors were encountered: