Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove link matcher API #2703

Closed
Tyriar opened this issue Feb 8, 2020 · 0 comments
Closed

Remove link matcher API #2703

Tyriar opened this issue Feb 8, 2020 · 0 comments
Labels
area/api breaking-change Breaks API and requires a major version bump type/debt Technical debt that could slow us down in the long run
Milestone
5.0.0

Comments

@Tyriar
Copy link
Member

Tyriar commented Feb 8, 2020

Tentatively assigning to v5, we can remove this API and remove Linkifier all together when:

  • VS Code has adopted the link provider API
  • Consumers have been informed about the link matcher API's removal (4.5 release notes) and we've given enough time to move off of it
  • WebLinksAddon has moved over to the link provider API (done with Basic link parser for better link detection #2530)
@Tyriar Tyriar added type/debt Technical debt that could slow us down in the long run breaking-change Breaks API and requires a major version bump area/api labels Feb 8, 2020
@Tyriar Tyriar added this to the 5.0.0 milestone Feb 8, 2020
@Tyriar Tyriar mentioned this issue Apr 11, 2020
Closed
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Jul 27, 2022
@Tyriar
Remove link matchers
7a17a26 
Fixes xtermjs#2703
@Tyriar Tyriar mentioned this issue Jul 27, 2022
Merged
@Tyriar Tyriar closed this as completed Jul 27, 2022
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Jul 27, 2022
@Tyriar
Remove mouse zone manager
7bd3801 
Part of xtermjs#2703
@Tyriar Tyriar mentioned this issue Jul 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/api breaking-change Breaks API and requires a major version bump type/debt Technical debt that could slow us down in the long run
Projects
None yet
Milestone
5.0.0
Development

No branches or pull requests
1 participant
@Tyriar