Merge pull request #2616 from sdegutis/patch-1

Avoid roundtrip to browser when double-disposing.
xtermjs · Dec 7, 2019 · ab66cb5 · ab66cb5
2 parents bd0d267 + c5e144f
commit ab66cb5
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/browser/Lifecycle.ts b/src/browser/Lifecycle.ts
@@ -17,12 +17,13 @@ export function addDisposableDomListener(
   useCapture?: boolean
 ): IDisposable {
   node.addEventListener(type, handler, useCapture);
+  let disposed = false;
   return {
     dispose: () => {
-      if (!handler) {
-        // Already disposed
+      if (!disposed) {
         return;
       }
+      disposed = true;
       node.removeEventListener(type, handler, useCapture);
     }
   };