Apply suggestions from code review

Co-authored-by: Daniel Imms <[email protected]>
xtermjs · Feb 2, 2021 · 5a965b1 · 5a965b1
1 parent 6982201
commit 5a965b1
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/addons/xterm-addon-web-links/src/WebLinkProvider.ts b/addons/xterm-addon-web-links/src/WebLinkProvider.ts
@@ -18,19 +18,21 @@ export class WebLinkProvider implements ILinkProvider {
 
   public provideLinks(y: number, callback: (links: ILink[] | undefined) => void): void {
     const links = LinkComputer.computeLink(y, this._regex, this._terminal, this._handler);
-    callback(this._addCallBacks(links, this._options.tooltipCallback, this._options.leaveCallback));
+    callback(this._addCallbacks(links, this._options.tooltipCallback, this._options.leaveCallback));
   }
 
-  private _addCallBacks(links: ILink[], hover?: (event: MouseEvent, uri: string, location: IViewportRange) => void, leave?: (event: MouseEvent, uri: string) => void): ILink[] {
-    return links.map((link): ILink => {
+  private _addCallbacks(links: ILink[], hover?: (event: MouseEvent, uri: string, location: IViewportRange) => void, leave?: (event: MouseEvent, uri: string) => void): ILink[] {
+    return links.map(link => {
       let hoverCallback = (event: MouseEvent, uri: string): void => { };
       if (hover) {
         hoverCallback = (event, uri): void => {
           const { range } = link;
           hover(event, uri, range);
         };
       }
-      return { ...link, leave, hover: hoverCallback };
+      link.leave = leave;
+      link.hover = hoverCallback;
+      return link;
     });
   }
 }