Merge pull request #2799 from Tyriar/enum_like_upper_case

Allow enum-like objects to use upper case naming
xtermjs · Mar 30, 2020 · 4602ffb · 4602ffb
2 parents 8ec41a7 + 8842625
commit 4602ffb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -74,6 +74,9 @@ module.exports = {
       { "selector": "memberLike", "modifiers": ["private"], "format": ["camelCase"], "leadingUnderscore": "require" },
       { "selector": "memberLike", "modifiers": ["protected"], "format": ["camelCase"], "leadingUnderscore": "require" },
       { "selector": "enumMember", "format": ["UPPER_CASE"] },
+      // memberLike - Allow enum-like objects to use UPPER_CASE
+      { "selector": "property", "modifiers": ["public"], "format": ["camelCase", "UPPER_CASE"] },
+      { "selector": "method", "modifiers": ["public"], "format": ["camelCase", "UPPER_CASE"] },
       // typeLike
       { "selector": "typeLike", "format": ["PascalCase"] },
       { "selector": "interface", "format": ["PascalCase"], "prefix": ["I"] },

diff --git a/src/common/services/CoreMouseService.ts b/src/common/services/CoreMouseService.ts
@@ -6,9 +6,6 @@ import { IBufferService, ICoreService, ICoreMouseService } from 'common/services
 import { EventEmitter, IEvent } from 'common/EventEmitter';
 import { ICoreMouseProtocol, ICoreMouseEvent, CoreMouseEncoding, CoreMouseEventType, CoreMouseButton, CoreMouseAction } from 'common/Types';
 
-// Disable naming convention as this file uses non-standard naming and it might be dangerous to change it
-/* eslint-disable @typescript-eslint/naming-convention */
-
 /**
  * Supported default protocols.
  */