Fix for threads and XS #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like threading and scalars made by *_share do not mix well.
sergeykolychev
force-pushed
the
threading2
branch
from
8e0d44d to
3452f6b
Compare
|
@sergeykolychev Thanks! I merge this PR. cf: gfx explains newSVpvn_share in his blog post in japanese |
skaji
added a commit
that referenced
this pull request
Aug 13, 2018
Changelog diff is:
diff --git a/Changes b/Changes
index 7e69336..808e88e 100644
--- a/Changes
+++ b/Changes
@@ -1,6 +1,8 @@
Revision history for Mouse
{{$NEXT}}
+
+v2.5.5 2018-08-13T15:41:32Z
- Warn if accessors overwrite methods/functions (ybrliiu #86, #90, #93)
- Fix for threads and XS; use newSVpvs instead of newSVpvs_share (sergeykolychev #92)
skaji
added a commit
that referenced
this pull request
Aug 13, 2018
Changelog diff is:
diff --git a/Changes b/Changes
index 808e88e..f31e5e0 100644
--- a/Changes
+++ b/Changes
@@ -2,6 +2,9 @@ Revision history for Mouse
{{$NEXT}}
+v2.5.6 2018-08-13T22:47:57Z
+ - Revert "Warn if accessors overwrite methods/functions" for now; it may cause crashes in perl 5.28.0 (#94)
+
v2.5.5 2018-08-13T15:41:32Z
- Warn if accessors overwrite methods/functions (ybrliiu #86, #90, #93)
- Fix for threads and XS; use newSVpvs instead of newSVpvs_share (sergeykolychev #92)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@skaji @gfx
Looks like threading and scalars made by *_share do not mix well.
This deprecates my earlier PR #91 because it's much cleaner fix.
I use Mouse extensively in my module https://metacpan.org/pod/AI::MXNet and all tests passed while using Mouse with change.