XEP-0372: Document how to reference non-body elements #1102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
horazont
added
Needs Author
Kev
reviewed
Sep 9, 2021
xep-0372.xml
Outdated
| begin='6' | ||
| end='13' | ||
| type='mention' | ||
| anchor='subject' |
There was a problem hiding this comment.
On the mailing list your example used fragment URIs so anchor='#subject' - was the change here deliberate?
There was a problem hiding this comment.
No this was a mistake. I've added the # now, thanks.
jcbrand
force-pushed
the
jcbrand/xep-0372-anchor-fragment
branch
from
0fd35e7
to
832894d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documents how the 'anchor' attribute can be used to disambiguate which text-containing element is being referred to.
I brought this up in the standards list here: https://mail.jabber.org/pipermail/standards/2021-August/038504.html
@Kev Please let me know if you agree with this approach.