Skip to content
This repository has been archived by the owner on Jan 20, 2025. It is now read-only.

Add "release" as a qualifier #21

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Add "release" as a qualifier #21

merged 1 commit into from
Aug 19, 2024

Conversation

liquidz
Copy link
Contributor

@liquidz liquidz commented Aug 17, 2024

What I did

As title says.

Expected behavior

Lettuce has RELEASE and M as version qualifiers.

It seems natural to assume that RELEASE is considered a newer version than M1.

Actual behavior

(version-clj.core/version-compare "6.4.0.M1" "6.4.0.RELEASE") ;; => 1

Copy link
Owner

@xsc xsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I agree this makes sense.

@xsc xsc merged commit 4396b52 into xsc:master Aug 19, 2024
2 of 3 checks passed
@xsc
Copy link
Owner

xsc commented Aug 19, 2024

I'll have to look at the CI pipeline in this repo. It has been a while. :) There will be a release sometime soon, is what I'm saying.

@liquidz
Copy link
Contributor Author

liquidz commented Aug 20, 2024

Thank you so much!

@xsc
Copy link
Owner

xsc commented Aug 20, 2024

Release Notes

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants