pybootchartgui: Support labeling custom annotations #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for specifying custom annotations either individually through the command line --annotate option, or in bulk through an input file. This can be useful for decorating the bootchart with other meaningful time-based data not directly associated with the starting and stopping of a process. When providing --annotate with a filename, the file should be formatted as follows: <label> <time> <label2> <time2> where <time> is in the format HH:MM:SS, and will be used to calculate a position in the graph based on the bootchart ending time (displayed in the graph's header). <label> will appear above the annotation in the process tree graph (above the seconds header label). If more than one label is given for a specific <time>, these will be concatenated and separated by '/'. This change also supports adding similarly formatted <time> values directly on the --annotate option along with process names, though not at the same time as a filename. Moves the ProcessTree instantiation above the annotation processing to take advantage of proc_tree.duration when calculating where <time> should appear on the bootchart. Signed-off-by: Kyle Russell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for specifying custom annotations either individually
through the command line --annotate option, or in bulk through an input
file. This can be useful for decorating the bootchart with other
meaningful time-based data not directly associated with the starting and
stopping of a process.
When providing --annotate with a filename, the file should be formatted
as follows:
where is in the format HH:MM:SS, and will be used to calculate a
position in the graph based on the bootchart ending time (displayed in
the graph's header). will appear above the annotation in the
process tree graph (above the seconds header label). If more than one
label is given for a specific , these will be concatenated and
separated by '/'.
This change also supports adding similarly formatted values
directly on the --annotate option along with process names, though not
at the same time as a filename.
Moves the ProcessTree instantiation above the annotation processing to
take advantage of proc_tree.duration when calculating where
should appear on the bootchart.
Signed-off-by: Kyle Russell [email protected]