Makefile: Add -n to gzip #106
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make the resulting files reproducible.
-n --no-name
When compressing, do not save the original file name and timestamp by default.
Signed-off-by: Robert Yang <[email protected]>
xrmx
reviewed
Nov 14, 2024
| gzip -c bootchartd.1 > $(DESTDIR)$(MANDIR)/$(PROGRAM_PREFIX)bootchartd$(PROGRAM_SUFFIX).1.gz | ||
| gzip -c pybootchartgui.1 > $(DESTDIR)$(MANDIR)/pybootchartgui.1.gz | ||
| gzip -n -c bootchart2.1 > $(DESTDIR)$(MANDIR)/bootchart2.1.gz | ||
| gzip -n -c bootchartd.1 > $(DESTDIR)$(MANDIR)/$(PROGRAM_PREFIX)bootchartd$(PROGRAM_SUFFIX).1.gz |
There was a problem hiding this comment.
Isn't this changing behavior if PROGRAM_PREFIX / PROGRAM_SUFFIX are set?
There was a problem hiding this comment.
I don't think so according to "man gzip":
-n --no-name
When compressing, do not save the original file name and timestamp by default. (The original name is always saved if the
name had to be truncated.) When decompressing, do not restore the original file name if present (remove only the gzip suf-
fix from the compressed file name) and do not restore the original timestamp if present (copy it from the compressed file).
This option is the default when decompressing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make the resulting files reproducible.
-n --no-name
When compressing, do not save the original file name and timestamp by default.