Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implemented random_near_llzero #507

Merged
merged 4 commits into from
Jan 17, 2025
Merged

implemented random_near_llzero #507

merged 4 commits into from
Jan 17, 2025

Conversation

Basdorsman
Copy link
Contributor

@Basdorsman Basdorsman self-assigned this Jan 8, 2025
@Basdorsman Basdorsman linked an issue Jan 8, 2025 that may be closed by this pull request
Verify and implement the replacement of less_than_llzero with random_near_llzero in likelihood.py #468
Closed
@thjsal
Copy link
Contributor

thjsal commented Jan 8, 2025

Your link to the associated issue is not working. It should be this: #468

I am fine with this change, but I suggest to also change X-PSI version number to 3.0.1 and mention this change in the Changelog.

MHoogkamer
MHoogkamer reviewed Jan 8, 2025
View reviewed changes
Copy link
Contributor

@MHoogkamer MHoogkamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Tuomo. After that, I think it's good to go!

@Basdorsman
Copy link
Contributor Author

By the way, I think we can remove likelihood.less_than_llzero() completely, is that right?

@thjsal
Copy link
Contributor

thjsal commented Jan 16, 2025

I changed the version number also in docs/source/conf.py and corrected a small typo in the Changelog. I think this looks good. And indeed, maybe likelihood.less_than_llzero() could be removed completely. Unless you think it is worth to keep it there if somebody still would use the function in their customised codes or tests (but sure if having a CustomLikelihood.py you can add this function there yourself as well).

@Basdorsman Basdorsman merged commit cadab79 into main Jan 17, 2025
5 checks passed
@Basdorsman Basdorsman deleted the 468-verify-and-implement-the-replacement-of-less_than_llzero-with-random_near_llzero-in-likelihoodpy branch January 17, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MHoogkamer MHoogkamer MHoogkamer left review comments

@thjsal thjsal thjsal approved these changes

@drannawatts drannawatts Awaiting requested review from drannawatts

Assignees

@Basdorsman Basdorsman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Verify and implement the replacement of less_than_llzero with random_near_llzero in likelihood.py
3 participants
@Basdorsman @thjsal @MHoogkamer