Fix Base64OutputStream on HHVM #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thekid
commented
Jun 19, 2017
| $pos= $l - $o; | ||
| }; | ||
| } else { | ||
| $this->write= Type::forName('function(var): var')->cast([$this->out, 'write']); |
There was a problem hiding this comment.
This is essentially Closure::fromCallable(), but this PHP 7.1 feature doesn't exist in HHVM yet, see facebook/hhvm#7874
Released in
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements the base64 output stream in userland on HHVM, working around facebook/hhvm#7659. See xp-framework/core#176
I first went down the way of implementing a php_user_filter class and exchanging the stream filter with this implementation, however, its
filter()method doesn't get invoked for the last chunk when the stream is closing due to facebook/hhvm#7889 - we need this to add potentially necessary padding.