Refactor: Class parser #59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before: 1.887 seconds After: 1.517 seconds (running core.ini tests)
| } | ||
| } | ||
| $annotations= []; | ||
| unset($meta[1][$m][DETAIL_ANNOTATIONS]['generic']); |
There was a problem hiding this comment.
This line with unset(...) was not ported, but does not fail any test so far.
|
Delaying this, the code currently works fine (albeit being hard to read) and I really don't want to bundle the entire xp-forge/parse library with XP core, especially not with xp-framework/rfc#296 coming up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests refactors the handcrafted class parsers and code operations into functionality in a new package,
lang.codedom.Scope
Performance
Before:
$ unittest src/test/config/unittest/core.ini # ... OK: 1951/1976 run (25 skipped), 1951 succeeded, 0 failed Memory used: 11187.97 kB (12127.07 kB peak) Time taken: 1.466 secondsAfter:
$ unittest src/test/config/unittest/core.ini # ... OK: 2044/2069 run (25 skipped), 2044 succeeded, 0 failed Memory used: 11600.63 kB (12574.12 kB peak) Time taken: 1.564 seconds~same