Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove wrapper types #118

Merged
merged 19 commits into from
Jan 23, 2016
Merged

Conversation

thekid
Copy link
Member

@thekid thekid commented Jan 21, 2016

Removes lang.types and all tests for it.

Reintroduces lang.types.Bytes as util.Bytes:

$ xp mirror util.Bytes                                                                      
@FileSystemCL<~/devel/xp/core/src/main/php>                                                 
public class util.Bytes implements lang.Value, ArrayAccess, IteratorAggregate {
  private var $buffer                                                                       
  private var $size                                                                         

  public __construct(var $initial)                                                          

  protected string asByte(var $in)                                                          
  public php.Iterator getIterator()                                                         
  public int offsetGet(int $offset)                                             
  public var offsetSet(int $offset, var $value)                                             
  public bool offsetExists(int $offset)                                                     
  public var offsetUnset(int $offset)                                                       
  public int size()                                                                         
  public int compareTo(var $value)                                                          
  public string hashCode()                                                                  
  public string toString()                                                                  
}                                                                                           ```

See xp-framework/rfc#298

@thekid thekid added the rfc label Jan 21, 2016
@thekid thekid modified the milestones: 6.9.0, 7.0.0 Jan 21, 2016
thekid added a commit that referenced this pull request Jan 23, 2016
@thekid thekid merged commit ae7b64c into xp-framework:master Jan 23, 2016
@thekid thekid deleted the refactor/remove-wrapper-types branch January 23, 2016 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant