Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HHVM builds broken #205

Closed
thekid opened this issue Sep 10, 2018 · 1 comment
Closed

HHVM builds broken #205

thekid opened this issue Sep 10, 2018 · 1 comment
Labels

Comments

@thekid
Copy link
Member

thekid commented Sep 10, 2018

See https://travis-ci.org/xp-framework/core/jobs/426839764:

Exception lang.Error (Class undefined: IllegalStateException)
  at <native>::Error(0, (0x26)'Class undefined: IllegalStateException')
  [line 132 of ConsoleTest.class.php]

The code here is:

try {
  Console::write(new class() implements Value {
    public function toString() { throw new IllegalStateException('Cannot render string'); }
    public function hashCode() { return get_class($this); }
    public function compareTo($value) { return 1; }
  });
  $this->fail('Expected exception not thrown', null, 'lang.IllegalStateException');
} catch (IllegalStateException $expected) {
  $this->assertEquals('', $this->streams[1]->getBytes());
}

Line 132 is the one with throw new IllegalStateException on it.

Problems caused by facebook/hhvm#8319

@thekid thekid added the php label Sep 10, 2018
@thekid
Copy link
Member Author

thekid commented Sep 10, 2018

...which is why I allowed HHVM to fail for the moment in f9cd7be

commit f9cd7bebc00b9aacc29e9245acea529619e41fc8
Author: U-UNITED\friebe <[email protected]>
Date:   Thu Sep 6 21:38:27 2018 +0200

    Allow HHVM to fail

    *Sigh*: lang.Error (Class undefined: IllegalStateException)... what is this?
    See https://travis-ci.org/xp-framework/core/jobs/425404766

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant