-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Safer settings reload and MQTT change detection #1701
Conversation
This reverts commit 580b8f8.
The best effect for settings RAM size is running Core 2.5.1 and up, with SSO optimization for String. Negligible fragmentation when strings are changing size (but still present when changing topic, only visible via heap fragmentation statistics ESP.getHeapStats(). see https://github.com/mcspr/espurna/compare/utils/fragmentation) To keep memory in check with current setup - In general, something can be done to getSetting / Embedis / some other storage abstraction. Embedis itself already uses 4k of eeprom, in theory some String-like object can point directly to the correct position in that buffer. However, if something changes everything needs to be invalidated. |
MQTT_SUPPORT
small optimization is to also set them to default inplace (
String _mqtt_server(MQTT_SERVER);
)