-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge RF and RFBridge code #1435
Conversation
I'd suggest to stick to rfbridge.ino as base and keep RFBRIDGE naming when appropriate (per #795 (comment) and general issue of still having either two or one direction rf communication modules) This does not modify modules behaviour, thus may be safely merged. Later PR can address RFB_DIRECT / RF_SUPPORT, RF_PIN / RFB_PIN etc. |
I agree with your comment on the filename and diff size - I updated the PR. I kept the function names (like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, besides comments
if @xoseperez does not mind rfbridge->rf naming
Thanks a lot, I missed that! PR has been updated now. |
Any chance that this can be merged? |
Related issue: #1425
This PR merges the RF and RF Bridge code. No changes in configs/defines. I also took the freedom to rename the module to generic "RF".