Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix no build_categorical_column error of GPU read_parquet #832

Merged
merged 45 commits into from
Dec 5, 2024

Conversation

hucorz
Copy link
Collaborator

@hucorz hucorz commented Dec 4, 2024

What do these changes do?

Use CategoricalColumn instead of build_categorical_column

Related issue number

#828

Relative pr in cudf:

rapidsai/cudf#16617

This pr gives an example how to Use CategoricalColumn instead of build_categorical_column:https://github.com/rapidsai/cugraph/pull/4618/files

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added enhancement New feature or request gpu labels Dec 4, 2024
@XprobeBot XprobeBot added this to the v0.7.4 milestone Dec 4, 2024
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.47%. Comparing base (183734a) to head (d21dec3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #832      +/-   ##
==========================================
+ Coverage   82.45%   82.47%   +0.01%     
==========================================
  Files        1071     1071              
  Lines       80168    80168              
  Branches    12207    12207              
==========================================
+ Hits        66105    66116      +11     
+ Misses      12504    12492      -12     
- Partials     1559     1560       +1     
Flag Coverage Δ
unittests 82.36% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luweizheng luweizheng changed the title ENH:Use CategoricalColumn instead of build_categorical_column BUG: Fix no build_categorical_column error of read_parquet Dec 5, 2024
@XprobeBot XprobeBot added bug Something isn't working and removed enhancement New feature or request labels Dec 5, 2024
@luweizheng luweizheng changed the title BUG: Fix no build_categorical_column error of read_parquet BUG: Fix no build_categorical_column error of GPU read_parquet Dec 5, 2024
Copy link
Collaborator

@luweizheng luweizheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luweizheng luweizheng merged commit dfcbf96 into xorbitsai:main Dec 5, 2024
38 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gpu
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants