Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add a check whether scheduling is stuck #695

Merged
merged 14 commits into from
Sep 21, 2023

Conversation

Flying-Tom
Copy link
Contributor

What do these changes do?

Use stagemonitor to trace and cancel those stale subtasks

Related issue number

Fixes #489

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added the enhancement New feature or request label Sep 12, 2023
@XprobeBot XprobeBot added this to the v0.6.1 milestone Sep 12, 2023
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #695 (d022c82) into main (fe7caba) will decrease coverage by 3.76%.
The diff coverage is 58.97%.

@@            Coverage Diff             @@
##             main     #695      +/-   ##
==========================================
- Coverage   93.50%   89.75%   -3.76%     
==========================================
  Files        1025     1025              
  Lines       79354    79377      +23     
  Branches    16441    16443       +2     
==========================================
- Hits        74203    71244    -2959     
- Misses       3466     6268    +2802     
- Partials     1685     1865     +180     
Flag Coverage Δ
unittests 89.64% <58.97%> (-3.76%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...orbits/_mars/services/scheduling/worker/service.py 100.00% <ø> (ø)
...bits/_mars/services/scheduling/worker/execution.py 86.59% <58.97%> (-11.62%) ⬇️

... and 127 files with indirect coverage changes

@XprobeBot XprobeBot modified the milestones: v0.6.1, v0.6.2 Sep 15, 2023
@aresnow1
Copy link
Contributor

test_mem_quota_allocation failed.

@XprobeBot XprobeBot modified the milestones: v0.6.2, v0.6.3 Sep 20, 2023
Copy link
Contributor

@aresnow1 aresnow1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! LGTM

@aresnow1 aresnow1 merged commit bc0c60c into xorbitsai:main Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: Add a check whether scheduling is stuck
3 participants