-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Diminish the notion of prelude #84
Milestone
Comments
xonixx
added a commit
that referenced
this issue
Dec 8, 2021
xonixx
added a commit
that referenced
this issue
Dec 8, 2021
xonixx
added a commit
that referenced
this issue
Dec 8, 2021
xonixx
added a commit
that referenced
this issue
Dec 8, 2021
xonixx
added a commit
that referenced
this issue
Dec 8, 2021
xonixx
added a commit
that referenced
this issue
Dec 8, 2021
xonixx
added a commit
that referenced
this issue
Dec 8, 2021
xonixx
added a commit
that referenced
this issue
Dec 8, 2021
xonixx
added a commit
that referenced
this issue
Dec 8, 2021
xonixx
added a commit
that referenced
this issue
Dec 8, 2021
Closed
xonixx
added a commit
that referenced
this issue
Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Discovered in #81 (comment)
What
Disallow arbitraty shell scripts in prelude area (i.e. before goals declaration).
Now allowed
Proposed
Only allow
@define
,@shell
,@options
and comment lines in prelude area, no plain shell codeWhy
@goal initialized
?How
We change the implementation to limit the flexibility of prelude or remove this notion altogether.
Need not forget to adjust README accordingly.
This could be a breaking change, need to find a way to cause least damage.
Things to consider
@define VAR='hello'
(as now) vs@define VAR 'hello'
(more consistent with other directives syntax)@define W=world
@define HW="Hello $W!"
@define A="$(curl https://google.com)"
Resolution
For release 0.9.15 let's proceed with gradual approach. We leave the current syntax
@define VAR="Value $OTHER_VAR"
but we remove the ability to run arbitrary shell in prelude area.Later we need to reconsider the syntax to make parsing more strict and unified, to disallow things like #85.
The text was updated successfully, but these errors were encountered: