False positive warning "Function ... is never used" #214 : more tests

src/main/java/intellij_awk/psi/AwkStringMixin.java

@@ -1,18 +1,18 @@
 package intellij_awk.psi;
 
+import static com.intellij.openapi.util.text.StringUtil.unquoteString;
+
 import com.intellij.lang.ASTNode;
 import com.intellij.openapi.util.TextRange;
 import com.intellij.psi.PsiElement;
 import com.intellij.psi.PsiReference;
 import intellij_awk.AwkReferenceFunction;
+import intellij_awk.AwkUtil;
+import java.util.regex.Pattern;
 import javax.swing.*;
 import org.jetbrains.annotations.NotNull;
 import org.jetbrains.annotations.Nullable;
 
-import java.util.regex.Pattern;
-
-import static com.intellij.openapi.util.text.StringUtil.unquoteString;
-
 public abstract class AwkStringMixin extends AwkNamedElementImpl {
   public AwkStringMixin(@NotNull ASTNode node) {
     super(node);
@@ -37,11 +37,15 @@ public PsiElement setName(String newName) {
 
   @Override
   public PsiReference getReference() {
-    return getName() != null
+    return getName() != null && isRhsOfAssignment()
         ? new AwkReferenceFunction(this, TextRange.from(1, getTextLength() - 2))
         : null;
   }
 
+  private boolean isRhsOfAssignment() {
+    return AwkUtil.isType(AwkUtil.getPrevNotWhitespace(getParent()), AwkTypes.ASSIGN);
+  }
+
   @Override
   public @Nullable Icon getIcon(int flags) {
     return null;

src/test/java/intellij_awk/AwkInspectionTests.java

@@ -316,6 +316,14 @@ public void testFuncRefToPreventUnusedFunc2_1() {
     checkByFile(unusedFunction);
   }
 
+  public void testFuncRefToPreventUnusedFunc3() {
+    checkByFileNoProblemAtCaret(unusedFunction);
+  }
+
+  public void testFuncRefToPreventUnusedFunc3_1() {
+    checkByFile(unusedFunction);
+  }
+
   @Override
   protected String getTestDataPath() {
     return "src/test/testData/inspection";

src/test/testData/inspection/funcRefToPreventUnusedFunc3.awk

@@ -0,0 +1,5 @@
+BEGIN {
+    print a = "fname"
+}
+
+function <caret>fname() {}

src/test/testData/inspection/funcRefToPreventUnusedFunc3_1.awk

@@ -0,0 +1,5 @@
+BEGIN {
+    print "fname"
+}
+
+function <caret>fname() {}

src/test/testData/inspection/funcRefToPreventUnusedFunc3_1After.awk

@@ -0,0 +1,4 @@
+BEGIN {
+    print "fname"
+}
+