Node 10.1.0, Chimp and fibers problem (can we upgrade fibers?) #690

joscha · 2018-05-18T07:40:06Z

Expected behaviour

Chimp installs as expected.

Actual behaviour

The fibers package fails to compile.

Exact steps to reproduce / repository that demonstrates the problem

after install of chimp:

    pushd ./node_modules/chimp/node_modules/fibers
    node ./build

Version & tools:

Chimp: type chimp -v 0.51.1
Node.js: type node -v 10.1.0
Operation system: type uname -v ubuntu xenial

Console / Log Output

xenial: gyp info using [email protected]
--
  | xenial: gyp info using [email protected] \| linux \| x64
  | xenial: gyp info spawn /usr/bin/python
  | xenial: gyp info spawn args [ '/usr/lib/node_modules/npm/node_modules/node-gyp/gyp/gyp_main.py',
  | xenial: gyp info spawn args   'binding.gyp',
  | xenial: gyp info spawn args   '-f',
  | xenial: gyp info spawn args   'make',
  | xenial: gyp info spawn args   '-I',
  | xenial: gyp info spawn args   '/var/lib/buildkite-agent/builds/canva-org/canva-web-build/web/node_modules/fibers/build/config.gypi',
  | xenial: gyp info spawn args   '-I',
  | xenial: gyp info spawn args   '/usr/lib/node_modules/npm/node_modules/node-gyp/addon.gypi',
  | xenial: gyp info spawn args   '-I',
  | xenial: gyp info spawn args   '/var/lib/buildkite-agent/.node-gyp/10.1.0/include/node/common.gypi',
  | xenial: gyp info spawn args   '-Dlibrary=shared_library',
  | xenial: gyp info spawn args   '-Dvisibility=default',
  | xenial: gyp info spawn args   '-Dnode_root_dir=/var/lib/buildkite-agent/.node-gyp/10.1.0',
  | xenial: gyp info spawn args   '-Dnode_gyp_dir=/usr/lib/node_modules/npm/node_modules/node-gyp',
  | xenial: gyp info spawn args   '-Dnode_lib_file=/var/lib/buildkite-agent/.node-gyp/10.1.0/<(target_arch)/node.lib',
  | xenial: gyp info spawn args   '-Dmodule_root_dir=/var/lib/buildkite-agent/builds/canva-org/canva-web-build/web/node_modules/fibers',
  | xenial: gyp info spawn args   '-Dnode_engine=v8',
  | xenial: gyp info spawn args   '--depth=.',
  | xenial: gyp info spawn args   '--no-parallel',
  | xenial: gyp info spawn args   '--generator-output',
  | xenial: gyp info spawn args   'build',
  | xenial: gyp info spawn args   '-Goutput_dir=.' ]
  | xenial: gyp info spawn make
  | xenial: gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]
  | xenial: make: Entering directory '/var/lib/buildkite-agent/builds/canva-org/canva-web-build/web/node_modules/fibers/build'
  | xenial:   CXX(target) Release/obj.target/fibers/src/fibers.o
  | xenial: ../src/fibers.cc: In function ‘v8::Handle<v8::String> uni::NewLatin1String(v8::Isolate*, const char*)’:
  | xenial: ../src/fibers.cc:122:64: error: no matching function for call to ‘v8::String::NewFromOneByte(v8::Isolate*&, const uint8_t*)’
  | xenial:    return String::NewFromOneByte(isolate, (const uint8_t*)string);
  | xenial:                                                                 ^
  | xenial: In file included from /var/lib/buildkite-agent/.node-gyp/10.1.0/include/node/node.h:63:0,
  | xenial:                  from ../src/coroutine.h:1,
  | xenial:                  from ../src/fibers.cc:1:
  | xenial: /var/lib/buildkite-agent/.node-gyp/10.1.0/include/node/v8.h:2736:51: note: candidate: static v8::MaybeLocal<v8::String> v8::String::NewFromOneByte(v8::Isolate*, const uint8_t*, v8::NewStringType, int)
  | xenial:    static V8_WARN_UNUSED_RESULT MaybeLocal<String> NewFromOneByte(
  | xenial:                                                    ^
  | xenial: /var/lib/buildkite-agent/.node-gyp/10.1.0/include/node/v8.h:2736:51: note:   candidate expects 4 arguments, 2 provided
  | xenial: ../src/fibers.cc: In function ‘v8::Handle<v8::String> uni::NewLatin1Symbol(v8::Isolate*, const char*)’:
  | xenial: ../src/fibers.cc:126:64: error: no matching function for call to ‘v8::String::NewFromOneByte(v8::Isolate*&, const uint8_t*)’
  | xenial:    return String::NewFromOneByte(isolate, (const uint8_t*)string);
  | xenial:                                                                 ^
  | xenial: In file included from /var/lib/buildkite-agent/.node-gyp/10.1.0/include/node/node.h:63:0,
  | xenial:                  from ../src/coroutine.h:1,
  | xenial:                  from ../src/fibers.cc:1:
  | xenial: /var/lib/buildkite-agent/.node-gyp/10.1.0/include/node/v8.h:2736:51: note: candidate: static v8::MaybeLocal<v8::String> v8::String::NewFromOneByte(v8::Isolate*, const uint8_t*, v8::NewStringType, int)
  | xenial:    static V8_WARN_UNUSED_RESULT MaybeLocal<String> NewFromOneByte(
  | xenial:                                                    ^
  | xenial: /var/lib/buildkite-agent/.node-gyp/10.1.0/include/node/v8.h:2736:51: note:   candidate expects 4 arguments, 2 provided
  | xenial: ../src/fibers.cc: In static member function ‘static void Fiber::DestroyOrphans()’:
  | xenial: ../src/fibers.cc:406:67: warning: ‘v8::String::Utf8Value::Utf8Value(v8::Local<v8::Value>)’ is deprecated: Use Isolate version [-Wdeprecated-declarations]
  | xenial:       String::Utf8Value stack(uni::Deref(that.isolate, fatal_stack));
  | xenial:                                                                    ^
  | xenial: In file included from /var/lib/buildkite-agent/.node-gyp/10.1.0/include/node/v8.h:26:0,
  | xenial:                  from /var/lib/buildkite-agent/.node-gyp/10.1.0/include/node/node.h:63,
  | xenial:                  from ../src/coroutine.h:1,
  | xenial:                  from ../src/fibers.cc:1:
  | xenial: /var/lib/buildkite-agent/.node-gyp/10.1.0/include/node/v8.h:2822:28: note: declared here
  | xenial:                    explicit Utf8Value(Local<v8::Value> obj));
  | xenial:                             ^
  | xenial: /var/lib/buildkite-agent/.node-gyp/10.1.0/include/node/v8config.h:318:3: note: in definition of macro ‘V8_DEPRECATED’
  | xenial:    declarator __attribute__((deprecated(message)))
  | xenial:    ^
  | xenial: ../src/fibers.cc: In static member function ‘static uni::FunctionType Fiber::New(const Arguments&)’:
  | xenial: ../src/fibers.cc:433:99: error: no matching function for call to ‘v8::Function::NewInstance(int, v8::Handle<v8::Value> [1])’
  | xenial:      return uni::Return(uni::Deref(Isolate::GetCurrent(), tmpl)->GetFunction()->NewInstance(1, argv), args);
  | xenial:                                                                                                    ^
  | xenial: In file included from /var/lib/buildkite-agent/.node-gyp/10.1.0/include/node/node.h:63:0,
  | xenial:                  from ../src/coroutine.h:1,
  | xenial:                  from ../src/fibers.cc:1:
  | xenial: /var/lib/buildkite-agent/.node-gyp/10.1.0/include/node/v8.h:3848:44: note: candidate: v8::MaybeLocal<v8::Object> v8::Function::NewInstance(v8::Local<v8::Context>, int, v8::Local<v8::Value>*) const
  | xenial:    V8_WARN_UNUSED_RESULT MaybeLocal<Object> NewInstance(
  | xenial:                                             ^
  | xenial: /var/lib/buildkite-agent/.node-gyp/10.1.0/include/node/v8.h:3848:44: note:   candidate expects 3 arguments, 2 provided
  | xenial: /var/lib/buildkite-agent/.node-gyp/10.1.0/include/node/v8.h:3851:44: note: candidate: v8::MaybeLocal<v8::Object> v8::Function::NewInstance(v8::Local<v8::Context>) const
  | xenial:    V8_WARN_UNUSED_RESULT MaybeLocal<Object> NewInstance(

Join our Slack xolv.io/community #chimp channel, where you can find help and help others.

The text was updated successfully, but these errors were encountered:

ghost · 2018-05-22T03:44:25Z

You should downgrade node version to v8.10.0

joscha · 2018-05-22T03:59:19Z

You should downgrade node version to v8.10.0

well it works on 9.x right now, but just in general I'd like to advance with Node versions instead of downgrading and staying on older versions.

celador · 2018-05-23T17:08:14Z

+1 on this one. Problem suddenly occurred during our CI process today.

thebarty · 2018-06-14T08:27:54Z

Same problem over here.

@joscha what's the current state. What's your workaround?

joscha · 2018-06-14T08:34:19Z

@joscha what's the current state. What's your workaround?

No good workaround unfortunately - we will most likely resort to the custom resolutions that yarn offers and then see if we can get on chimp vNext asap

joscha · 2018-06-26T03:58:33Z

Upgrading/resolving fibers to 2.0.2 doesn't seem to work - probably because of laverdet/node-fibers#379 - will try HEAD.

joscha · 2018-06-26T04:12:14Z

I take that back, this seems to work:

index d0d1e12a40a..d2b41f8f023 100644
--- a/web/package.json
+++ b/web/package.json
@@ -159,7 +159,7 @@
-    "node-gyp": "^3.6.2",
+    "node-gyp": "^3.7.0",
@@ -245,10 +245,13 @@
   "resolutions": {
+    "chimp/fibers": "^2.0.2",
+    "chimp/**/fibers": "^2.0.2",
+    "chimp/fibers/node-gyp": "^3.7.0"
   },
 }

fsevents still errors, possibly it needs a resolution as well or chokidar which uses fsevents in chimp.

joscha · 2018-06-26T07:08:04Z

another resolution for

  "fsevents": "^1.2.4",

fixes it. That is quite widespread though, so might be worth waiting for it to be picked up separately by projects.

joscha · 2018-07-11T05:06:58Z

@samhatoum any chance to get these deps bumped?

Ziinc · 2018-08-08T14:04:04Z

@joscha does your workaround involve installing [email protected] ?

joscha · 2018-08-08T14:18:53Z

@Ziinc yes, see #690 (comment)

samhatoum · 2018-11-09T19:20:20Z

This issue is being tracked in Chimpy
https://github.com/TheBrainFamily/chimpy/issues

samhatoum mentioned this issue Jul 21, 2018

Node 10.1.0, Chimp and fibers problem (can we upgrade fibers?) TheBrainFamily/chimpy#116

Open

samhatoum closed this as completed Nov 9, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Node 10.1.0, Chimp and fibers problem (can we upgrade fibers?) #690

Node 10.1.0, Chimp and fibers problem (can we upgrade fibers?) #690

joscha commented May 18, 2018

ghost commented May 22, 2018

joscha commented May 22, 2018

celador commented May 23, 2018

thebarty commented Jun 14, 2018

joscha commented Jun 14, 2018

joscha commented Jun 26, 2018

joscha commented Jun 26, 2018

joscha commented Jun 26, 2018

joscha commented Jul 11, 2018

Ziinc commented Aug 8, 2018

joscha commented Aug 8, 2018

samhatoum commented Nov 9, 2018

Node 10.1.0, Chimp and fibers problem (can we upgrade fibers?) #690

Node 10.1.0, Chimp and fibers problem (can we upgrade fibers?) #690

Comments

joscha commented May 18, 2018

Expected behaviour

Actual behaviour

Exact steps to reproduce / repository that demonstrates the problem

Version & tools:

Console / Log Output

ghost commented May 22, 2018

joscha commented May 22, 2018

celador commented May 23, 2018

thebarty commented Jun 14, 2018

joscha commented Jun 14, 2018

joscha commented Jun 26, 2018

joscha commented Jun 26, 2018

joscha commented Jun 26, 2018

joscha commented Jul 11, 2018

Ziinc commented Aug 8, 2018

joscha commented Aug 8, 2018

samhatoum commented Nov 9, 2018