test: add a test for allowing numbers in ionice class #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xolox you still working on this project? |
xolox
added a commit
that referenced
this pull request
Feb 13, 2020
xolox
added a commit
that referenced
this pull request
Feb 13, 2020
|
Hi @eyJhb, thanks for the feedback and sorry about not following up after I merged xolox/python-executor/pull/16. From my perspective it was done but clearly I could have followed up more thoroughly. I just merged this pull request and released rotate-backups 7.1 which explicitly supports numeric |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently not possible to user numbers for ionice, which it should be when running busybox implementation of ionice.
Look at pull request xolox/python-executor/pull/16 for more information :)
EDIT: Keep in mind, this will fail until the dependency from python-executor gets updated.