Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flatten: get rid of stale output custom type terminals #2025

Merged
merged 2 commits into from
Aug 28, 2020
Merged

Fix flatten: get rid of stale output custom type terminals #2025

merged 2 commits into from
Aug 28, 2020

Conversation

brusherru
Copy link
Contributor

There is no issue.
You can reproduce the bug by transpiling ("Show Code for Arduino") the xod-dev/esp8266-mcu/example-get-data-from-dweet patch.

Or you can create a minimal patch to reproduce the bug. Note, that there is a nested patch with a branch: one link directly to the output, another one — to the format-color node.

+-----------+
| color-hsl |
|           |
+-----O-----+
      |
      |
+-----O----------------+
|     |                |
|     +-------|        |
|     |     +-O------+ |
|     |     |        | |
|     |     | format | |
|     |     |        | |
|     |     +-O------+ |
|     |       |        |
|     |       |        |
+-----O-------O--------+

    CLR      STR

@brusherru brusherru self-assigned this Aug 25, 2020
evgenykochetkov
evgenykochetkov approved these changes Aug 28, 2020
View reviewed changes
Copy link
Contributor

@evgenykochetkov evgenykochetkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏻

@brusherru brusherru force-pushed the fix-stale-output-terminals-without-links-below branch from 6363186 to 33619d8 Compare August 28, 2020 14:05
@brusherru brusherru merged commit 6bfa1a6 into master Aug 28, 2020
@brusherru brusherru deleted the fix-stale-output-terminals-without-links-below branch August 28, 2020 14:38
@evgenykochetkov evgenykochetkov mentioned this pull request Sep 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evgenykochetkov evgenykochetkov evgenykochetkov approved these changes

@nkrkv nkrkv nkrkv approved these changes

Assignees

@brusherru brusherru

Labels
s:core t:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brusherru @nkrkv @evgenykochetkov