Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing dependency for xod-dev/pn532-nfc #2024

Merged
merged 1 commit into from
Aug 19, 2020
Merged

Add missing dependency for xod-dev/pn532-nfc #2024

merged 1 commit into from
Aug 19, 2020

Conversation

evgenykochetkov
Copy link
Contributor

Reported by @S-VIN.

Adafruit-PN532 library depends on Adafruit_BusIO and won't compile without it.

@evgenykochetkov evgenykochetkov self-assigned this Aug 18, 2020
brusherru
brusherru approved these changes Aug 19, 2020
View reviewed changes
Copy link
Contributor

@brusherru brusherru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

But probably we have to think about feature how to point on a specific version to avoid such bugs 🤔

@evgenykochetkov evgenykochetkov merged commit 41d4cf1 into master Aug 19, 2020
@evgenykochetkov evgenykochetkov deleted the fix-PN532-dependencies branch August 19, 2020 12:44
@evgenykochetkov evgenykochetkov mentioned this pull request Sep 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brusherru brusherru brusherru approved these changes

@nkrkv nkrkv nkrkv approved these changes

@gabbapeople gabbapeople Awaiting requested review from gabbapeople

Assignees

@evgenykochetkov evgenykochetkov

Labels
s:stdlib t:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evgenykochetkov @nkrkv @brusherru