Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in flattening when uppermost custom type terminal has no input links #2023

Merged
merged 1 commit into from
Aug 21, 2020

Conversation

brusherru
Copy link
Contributor

You can reproduce the bug by compiling/transpiling the xod-dev/st-mems/example patch.

@brusherru brusherru self-assigned this Aug 18, 2020
@brusherru brusherru force-pushed the fix-flatten-for-unbound-custom-type branch from 554a3bd to b2d2940 Compare August 19, 2020 10:32
Copy link
Contributor

@evgenykochetkov evgenykochetkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

(but a test would be nice)

Copy link
Member

@nkrkv nkrkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with the test requirement

@brusherru brusherru force-pushed the fix-flatten-for-unbound-custom-type branch from b2d2940 to 50ed026 Compare August 19, 2020 11:17
@brusherru
Copy link
Contributor Author

@nkrkv @evgenykochetkov done!

…ting cast nodes for custom types) in case when the uppermost terminal has no input links
@brusherru brusherru force-pushed the fix-flatten-for-unbound-custom-type branch from 50ed026 to 9d0c62c Compare August 19, 2020 15:43
@brusherru brusherru merged commit 40813a5 into master Aug 21, 2020
@brusherru brusherru deleted the fix-flatten-for-unbound-custom-type branch August 21, 2020 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants