-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tethering inet bugs, introduce a few new nodes and five new chapters of tutorial #1998
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
passed through the Grammarly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 015-xod-cloud
example works kind of weird.
I attached a count
with a watch
to cloud-store
's DONE
output and run the simulations.
After 5 or 6 changes with the interval of about 20 seconds, the counter was incremented only once, and the feed shows only the first 3 values.
8b34f9c
to
ed71507
Compare
ed71507
to
7554dfd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hyperlink UTM’s are missing
…se in tethering-inet
…d/stream` library
…meric values from feeds
7554dfd
to
b52c85b
Compare
@nkrkv please, pay attention to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Take two
b52c85b
to
0a00a34
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
I suggest one more structural change, though. Currently, if you get rid of numbers, here are chapters we get:
- internet (uses XOD Cloud)
- xod-cloud (talks about Feeds)
- internet (duplicate name)
- standalone-internet
Suggest making the difference apparent:
014-internet-tethering
015-xod-cloud-feeds
111-feed-messaging
112-standalone-internet
The H1 titles inside the chapters are better to match the filename.
Anther issue is with 014
chapter. You’re asking a user to “Place a tweak-pulse
node” but it is there already. Suggest reverting the patch itself to the state whet INIT
had Boot
bound to it.
…t while it has already opened connection
…sponse data on connection close
0a00a34
to
d622a43
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woohoo
This PR includes a lot of things. Probably better to divide it for a few commits, but then it blocks the main goal: create five new chapters of the tutorial, that really works :)
New library:
xod-cloud/basics
, that has nodes to get a DateTime and external IP, using our httpbin API.New nodes:
xod/stream/parse-u32
— to parseuint32
integers and returns as 4 bytes. Without this node parsing numbers such as a POSIX time has a big inaccuracy, because of converting to Float.xod/stream/parse-number
— actually parses a float from a string. Used in thecloud-number
node.xod-cloud/feeds/cloud-string
— get a string from a feedxod-cloud/feeds/cloud-number
— get a number from a feedxod-cloud/feeds/cloud-boolean
— get a boolean from a feedxod/datetime/from-posix
— a new constructorxod/datetime/to-posix
— a new destructorNew chapters of the tutorial:
013-custom-types
— introduce to custom types using adatetime
type014-internet
— introduce to tethering-inet a receiving a current DateTime015-xod-cloud
— introduce to XOD Cloud Feeds111-internet
— rotating servo using the data from feeds and tethering internet112-standalone-internet
— replacingtethering-inet
with another internet provider node (probably should be renamed to something shorter)