Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed uv_geostrophic #65

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Fixed uv_geostrophic #65

merged 1 commit into from
Feb 9, 2024

Conversation

kthyng
Copy link
Contributor

@kthyng kthyng commented Feb 9, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
* algorithm was incorrect, now fixed
* updated docs to mostly run (fixed xesmf issue in docs conf.py, conda-forge/esmf-feedstock#91 (comment))
* updated formatting in docs
@kthyng
Copy link
Contributor Author

kthyng commented Feb 9, 2024

This fix addresses #63

@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0c61799) 83.93% compared to head (0a461c2) 83.93%.
Report is 4 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #65   +/-   ##
=======================================
  Coverage   83.93%   83.93%           
=======================================
  Files          17       17           
  Lines        1898     1898           
=======================================
  Hits         1593     1593           
  Misses        305      305           
Flag Coverage Δ
unittests 83.93% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kthyng kthyng merged commit 9d2343c into xoceanmodel:main Feb 9, 2024
11 checks passed
@kthyng kthyng deleted the fix_geostrophic branch February 9, 2024 18:40
@kthyng kthyng linked an issue Feb 9, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in derived.py for uv_geostrophic function of XROMS
2 participants