Read your own group writes #415
Conversation
|
Warning Rate limit exceeded@mkysel has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 0 minutes and 40 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughThis pull request introduces enhancements to the message publishing mechanism and testing infrastructure. In the Changes
Sequence DiagramsequenceDiagram
participant Client
participant Service
participant PublishWorker
Client->>Service: Publish Envelope
Service->>PublishWorker: Stage Envelope
PublishWorker->>PublishWorker: Process Envelope
PublishWorker-->>Service: Update lastProcessed
Service->>Service: Wait for Processing
Service-->>Client: Return Response
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
pkg/server/server_test.go (1)
215-279: Enhance test coverage for read-your-own-writes guarantee.While the test verifies the basic functionality, consider adding test cases for:
- Multiple concurrent writes
- Error cases (e.g., timeout scenarios)
- Performance under load
Would you like me to generate additional test cases to improve coverage?
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
pkg/api/message/publishWorker.go(3 hunks)pkg/api/message/service.go(2 hunks)pkg/server/server_test.go(5 hunks)
🔇 Additional comments (5)
pkg/api/message/publishWorker.go (2)
17-24: LGTM! Thread-safe tracking of processed envelopes.The
lastProcessedfield usingatomic.Int64ensures thread-safe tracking of envelope IDs.
97-97: LGTM! Proper update of the last processed ID.The ID is stored after successful processing, ensuring accurate tracking.
pkg/api/message/service.go (1)
353-353: LGTM! Ensures read-your-own-writes guarantee.The call to
waitForGatewayPublishensures that the write is processed before responding to the client.pkg/server/server_test.go (2)
33-44: LGTM! Dynamic port allocation improves test reliability.Using dynamic port allocation prevents port conflicts in parallel test execution.
76-79: LGTM! Proper configuration of the Payer options.The Payer configuration now includes the private key, ensuring proper authentication.
This does not solve all possible cases of read-your-own-writes, but it makes things a little bit easier.
This guarantees that when a node confirms a payer write, future reads will return the data.
This does not guarantee:
I added the debug log so we can see how long the delay is. In general, it is usually one busy-wait cycle. But could be more on busy systems. It is rarely 0 cycles.
Relates to #358
Summary by CodeRabbit
New Features
Tests
Chores