Protect mocks against circular depdency #158
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 12, 2024
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
neekolas
force-pushed
the
09-12-protect_mocks_against_circular_depdency
branch
from
8539d63 to
288d1ce
Compare
Your org has enabled the Graphite merge queue for merging into mainAdd the label “Queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “Hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
richardhuaaa
approved these changes
Sep 12, 2024
neekolas
force-pushed
the
09-11-create_validation_service
branch
from
8c7f7e2 to
ea9725c
Compare
neekolas
force-pushed
the
09-12-protect_mocks_against_circular_depdency
branch
from
288d1ce to
1875117
Compare
Merge activity
|
neekolas
added a commit
that referenced
this pull request
Sep 12, 2024
## tl;dr - Having all the mocks in the same folder can lead to circular dependencies if _any_ of the mocks reference a package that needs to use a mock - This puts each mock package in a folder that matches the `PackageName` which should be a safer approach long-term.
graphite-app
bot
deleted the
09-12-protect_mocks_against_circular_depdency
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr
PackageNamewhich should be a safer approach long-term.