Restart filter on disconnects #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempts to restart the filter in a loop until the node comes back online.
Deploying with
|
| Latest commit: |
e15cfec
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bee475d1.xmtp-js.pages.dev |
| Branch Preview URL: | https://reconnect-filter.xmtp-js.pages.dev |
snormore
approved these changes
Jul 7, 2022
|
🎉 This PR is included in version 4.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
js-libp2pwhere no events are emitted when connections close, because some streams are hanging open. This is borrowed from status web's implementation of js-waku. https://github.com/status-im/status-web/pull/288/files#Notes
It's unclear whether this will actually catch our deploys, since the load balancer should be handling them in a 0-downtime way. Unless we are very lucky with the timing of the loop, I am not sure this event will trigger. It might, but I haven't been able to find a good way to test that locally, since it is dependent on the AWS LB behavior. If not, we will have to wait for the underlying connection monitoring issue in LibP2P to be fixed upstream before we have a solution to that case. But this will definitely help with any case of temporary downtime of our nodes.