feat: implement grpc_gateway api client #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmccartney
force-pushed
the
daniel-api-gateway
branch
7 times, most recently
from
35ff5ac to
8948a20
Compare
Comment on lines
+56
to
+57
| #[cfg_attr(not(target_arch = "wasm32"), async_trait)] | ||
| #[cfg_attr(target_arch = "wasm32", async_trait(?Send))] |
There was a problem hiding this comment.
Out of curiosity, what is the reasoning behind this? We need Send on non-wasm, but we don't need it on wasm?
There was a problem hiding this comment.
Yep, that's right -- I know, it's an eyesore :( (more info here).
More generally, I don't love the look of this yet. But I was thinking to revisit it after / as I sort out how to implement the subscribe() call since I suspect it will have the gnarlier concurrency issues.
There was a problem hiding this comment.
That's totally fine, makes sense to prioritize other things! The surface area of this work is so large. Just wanted to understand it for future reference
dmccartney
force-pushed
the
daniel-api-gateway
branch
2 times, most recently
from
d97e9b8 to
4191f08
Compare
dmccartney
force-pushed
the
daniel-api-gateway
branch
6 times, most recently
from
81e6238 to
4d448d2
Compare
jhaaaa
reviewed
Sep 29, 2023
neekolas
reviewed
Sep 29, 2023
| QueryResponse, SubscribeRequest, | ||
| }; | ||
|
|
||
| // TODO: consider moving these (and other address const) into `xmtp_proto` |
neekolas
approved these changes
Sep 29, 2023
dmccartney
force-pushed
the
daniel-api-gateway
branch
from
4d448d2 to
1ed1a1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This begins the implementation of the wasm-friendly grpc-gateway API client.
It continues where #217 left off.
xmtp_networkingintoxmtp_api_grpcandxmtp_api_grpc_gatewayxmtp_api_grpc_gatewayQueryPublishBatchQueryFuture PR
Subscribexmtpsurgery to make storage layer swappable