This repository has been archived by the owner on Sep 26, 2023. It is now read-only.
Fix issue removing subscriptions #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snormore
approved these changes
Jul 26, 2022
mkobetic
reviewed
Jul 26, 2022
| subCfs := subscriber.filter.ContentFilters | ||
| for _, cf := range subCfs { | ||
| for i, cf := range subCfs { | ||
| if cf.ContentTopic == contentFilter.ContentTopic { | ||
| l := len(subCfs) - 1 | ||
| subCfs[l], subCfs[i] = subCfs[i], subCfs[l] |
There was a problem hiding this comment.
seems that this could just be subCfs[i] = subCfs[l] given that we're dropping subCfs[l] on the next line.
There was a problem hiding this comment.
You're right. Simplified.
elisealix22
approved these changes
Jul 26, 2022
mkobetic
reviewed
Jul 26, 2022
| if cf.ContentTopic == contentFilter.ContentTopic { | ||
| l := len(subCfs) - 1 | ||
| subCfs[l], subCfs[i] = subCfs[i], subCfs[l] | ||
| subscriber.filter.ContentFilters = subCfs[:l] | ||
| } | ||
| } | ||
| sub.subscribers[subIndex] = subscriber |
There was a problem hiding this comment.
Ah, right, []Subscriber instead of []*Subscriber, it's messy when you don't use pointers. Alternative would be to set subscriber := &(sub.subscribers[subIndex]) up top, but this works too.
There was a problem hiding this comment.
Took me a while banging my head against the wall to notice that one...
This was referenced Jul 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Notes