Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ValueObject interface for KMolecules #100

Closed
NathanCAllen opened this issue Jul 30, 2023 · 7 comments
Closed

ValueObject interface for KMolecules #100

NathanCAllen opened this issue Jul 30, 2023 · 7 comments
Assignees
@odrotbohm
Labels
module: ddd Domain-Driven Design related support type: enhancement New feature or request
Milestone
1.9

Comments

@NathanCAllen
Copy link

Since #51 was implemented before #55, ValueObject was never added as an interface in KMolecules.

I'd create the PR for this myself, but I don't have write access to the repo.
denniseffing added a commit to denniseffing/jmolecules that referenced this issue Aug 2, 2023
@denniseffing
xmoleculesGH-100 - Add Kotlin ValueObject counterpart to kmolecules-ddd
0d8e91a
@denniseffing
Copy link
Contributor

denniseffing commented Aug 2, 2023 •
edited
Loading

I created a PR for this issue as I just stumbled upon this as well.

#101

@NathanCAllen You don't need write access to a repository to create a PR, you can fork the repository, push your changes on a branch and then open up a PR in the original repository.

odrotbohm pushed a commit that referenced this issue Aug 17, 2023
@denniseffing @odrotbohm
GH-100 - Add Kotlin ValueObject counterpart to kmolecules-ddd.
e839c3c
odrotbohm added a commit that referenced this issue Aug 17, 2023
@odrotbohm
GH-100 - Polishing.
c5324d9 
Added missing license header. Simplify SimpleAssociation.equals(…).
@odrotbohm odrotbohm added this to the 1.9 milestone Aug 17, 2023
@odrotbohm odrotbohm self-assigned this Aug 17, 2023
@odrotbohm odrotbohm added type: enhancement New feature or request module: ddd Domain-Driven Design related support labels Aug 17, 2023
@odrotbohm
Copy link
Member

That's merged, thanks!

@odrotbohm odrotbohm linked a pull request Aug 17, 2023 that will close this issue
Add Kotlin ValueObject counterpart to kmolecules-ddd #101
Closed
@mstine
Copy link

mstine commented Aug 17, 2023

Possible to get a release containing this fix quickly? I'm unfortunately unable to pull external snapshot dependencies.

@odrotbohm
Copy link
Member

Kotlin? Have you switched to the dark side, Matt? 😜 I can wrap up a release tomorrow (Friday).

@mstine
Copy link

mstine commented Aug 17, 2023 •
edited
Loading

Kotlin is the dark side? 😂 At first glance I thought you were teasing me about my snapshots policy. At any rate, I've been writing pretty much 100% Kotlin since mid-2020. Oops.

Also, thanks! I've been following JMolecules from afar for awhile, but I'm finally getting a chance to use it!

@odrotbohm
Copy link
Member

No package scope -> dark side. A hill I am wiling to die on. 😬

@mstine
Copy link

mstine commented Aug 18, 2023

You're not wrong. I don't like it either. But cost/benefit to me has worked out pretty well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@odrotbohm odrotbohm

Labels
module: ddd Domain-Driven Design related support type: enhancement New feature or request
Projects
None yet
Milestone
1.9
Development

Successfully merging a pull request may close this issue.

Add Kotlin ValueObject counterpart to kmolecules-ddd denniseffing/jmolecules
4 participants
@mstine @odrotbohm @denniseffing @NathanCAllen