Use most recent OpenSSL release when doing static build #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathangreen
force-pushed
the
feature/latest-openssl-release
branch
from
8e76030 to
1e36e4d
Compare
jonathangreen
force-pushed
the
feature/latest-openssl-release
branch
3 times, most recently
from
ba0b9d6 to
84f7c87
Compare
|
@mxamin I merged the commits you made today into this PR, and resolved the merge conflicts. This PR has the manylinux builds working with OpenSSL Might be worth considering pulling this in, so that OpenSSL versions stay up to date. |
|
If you would like something more minimal here let me know as well. I can make a PR with just the changes needed to build the manylinux wheels with OpenSSL 3.2.1 without the changes to automatically default to the latest OpenSSL release. |
|
@jonathangreen can you rebase the changes with master? I fix the opensuse-bumbleweed workflow, I want to make sure your changes won't impact that :) |
jonathangreen
force-pushed
the
feature/latest-openssl-release
branch
from
84f7c87 to
73cca3c
Compare
|
@mxamin done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if you didn't pass the
PYXMLSEC_OPENSSL_VERSIONenvironment variable, setup.py would default to1.1.1q. This PR updates setup.py to pull in the most recent OpenSSL version instead, which seems like a safer default, and matches what we do with the other libraries we download in the static build.