Skip to content

Commit

Permalink
fix(blog): upgrade scullyio
Browse files Browse the repository at this point in the history
  • Loading branch information
xmlking committed Jan 28, 2020
1 parent 5cc3b29 commit 0440f48
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 26 deletions.
3 changes: 1 addition & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,7 @@ ng build --prod --localize
ng build
# build scully blog
# options --showBrowser, --project
yarn run scully
yarn run scully --project webapp # alternative
yarn run scully --project webapp
# serve static content
yarn run lite-server

Expand Down
4 changes: 2 additions & 2 deletions libs/blog/src/lib/blog.module.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { NgModule } from '@angular/core';
import { RouterModule } from '@angular/router';
import { ComponentsModule } from '@scullyio/ng-lib';
import { ScullyLibModule } from '@scullyio/ng-lib';
import { SharedModule } from '@yeti/shared';
import { BlogPreviewComponent } from './components/blog-preview/blog-preview.component';
import { BlogOverviewComponent } from './containers/blog-overview/blog-overview.component';
Expand All @@ -9,7 +9,7 @@ import { BlogPostComponent } from './containers/blog-post/blog-post.component';
@NgModule({
imports: [
SharedModule,
ComponentsModule,
ScullyLibModule,

RouterModule.forChild([
/* {path: '', pathMatch: 'full', component: InsertYourComponentHere} */
Expand Down
7 changes: 2 additions & 5 deletions libs/home/src/lib/containers/landing/landing.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,8 @@ import { IdleMonitorService } from '@scullyio/ng-lib';
changeDetection: ChangeDetectionStrategy.OnPush
})
export class LandingComponent implements OnInit {
constructor(private idle: IdleMonitorService) {
// this.idle.idle$.subscribe(res => {
// console.log(res);
// });
}
// TODO remove IdleMonitorService
constructor(private idle: IdleMonitorService) {}

ngOnInit() {}

Expand Down
8 changes: 4 additions & 4 deletions scully.webapp.config.js
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
const {voidPlugin} = require('./tools/scully-plugins/void-plugin.js');
require("@scullyio/scully/routerPlugins/ignoredRoutePlugin")

exports.config = {
/** projectRoot is mandatory! */
projectRoot: './apps/webapp/src/app',
// TODO: Remove projectRoot
projectRoot: './apps/webapp/tsconfig.app.json',
outDir: './dist/static/apps/webapp',
routes: {
'/home/blog/:id': {
type: 'contentFolder',
id: { folder: './libs/blog/posts' }
},
'/home/callback': {
type: 'void',
type: 'ignored',
}
}
};
13 changes: 0 additions & 13 deletions tools/scully-plugins/void-plugin.js

This file was deleted.

0 comments on commit 0440f48

Please sign in to comment.