Add wrpcontext package, Add new decoder #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
renaz6
commented
Mar 30, 2023
renaz6
commented
- closes Add a wrpcontext subpackage #114 and Add a standard way of decoding a *http.Request into a message #115
Codecov Report
@@ Coverage Diff @@
## main #116 +/- ##
==========================================
+ Coverage 44.91% 45.03% +0.12%
==========================================
Files 24 24
Lines 4629 4667 +38
==========================================
+ Hits 2079 2102 +23
- Misses 2367 2380 +13
- Partials 183 185 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
johnabass
requested changes
Apr 6, 2023
denopink
requested changes
Apr 7, 2023
|
SonarCloud Quality Gate failed. |
johnabass
reviewed
Apr 12, 2023
| @@ -196,3 +197,132 @@ func TestDecodeRequestHeaders(t *testing.T) { | |||
| t.Run("Success", testDecodeRequestHeadersSuccess) | |||
| t.Run("Invalid", testDecodeRequestHeadersInvalid) | |||
| } | |||
|
|
|||
| func testDecodeRequestSuccess(t *testing.T) { | |||
There was a problem hiding this comment.
Not a blocker, but we should start moving consistently to github.com/stretchr/testify/suite for test suites. That makes these kinds of subtests much clearer and easier to implement and maintain.
There was a problem hiding this comment.
Added this issue to cover this work: #121
johnabass
approved these changes
Apr 12, 2023
denopink
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.