Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional headers to auth request #361

Merged
merged 1 commit into from
Jun 2, 2021
Merged

Conversation

schmidtw
Copy link
Member

@schmidtw schmidtw commented Jun 2, 2021

This adds the set of headers from the convey header into the auth
request in a way that doesn't require a change to Themis.

This adds the set of headers from the convey header into the auth
request in a way that doesn't require a change to Themis.
@schmidtw schmidtw requested a review from sadhyama June 2, 2021 07:59
@schmidtw
Copy link
Member Author

schmidtw commented Jun 2, 2021

I want to get some more thoughts from here: xmidt-org/xmidt#50 before we merge, but let me know what you think of the change @sadhyama .

@codecov
Copy link

codecov bot commented Jun 2, 2021

Codecov Report

Merging #361 (441ecf7) into master (bdc2733) will decrease coverage by 0.06%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #361      +/-   ##
==========================================
- Coverage   93.88%   93.82%   -0.07%     
==========================================
  Files          53       53              
  Lines        9782     9783       +1     
==========================================
- Hits         9184     9179       -5     
- Misses        598      604       +6     
Flag Coverage Δ
unittests 93.82% <92.85%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/test_auth_token_more.c 62.50% <0.00%> (-4.17%) ⬇️
src/auth_token.c 99.22% <97.22%> (-0.03%) ⬇️
tests/test_auth_token.c 100.00% <100.00%> (ø)
tests/test_config.c 94.39% <100.00%> (+0.03%) ⬆️
tests/test_service_alive.c 84.61% <0.00%> (-1.93%) ⬇️
tests/test_client_list.c 95.77% <0.00%> (-1.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdc2733...441ecf7. Read the comment docs.

@sadhyama
Copy link
Contributor

sadhyama commented Jun 2, 2021

I want to get some more thoughts from here: xmidt-org/xmidt#50 before we merge, but let me know what you think of the change @sadhyama .

PR changes looks fine @schmidtw . Thanks

@schmidtw schmidtw merged commit 77b587a into master Jun 2, 2021
@schmidtw schmidtw deleted the proposed-add-auth-headers branch June 2, 2021 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants