Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove bascule #265

Merged
merged 8 commits into from
Nov 18, 2024
Merged

Remove bascule #265

merged 8 commits into from
Nov 18, 2024

Conversation

maurafortino
Copy link
Contributor

@maurafortino maurafortino commented Nov 11, 2024 •
edited
Loading

Removed bascule from the transport.go file
TODO: update tests in transport_test file;
Discussion: not sure if the bascule replacement code is the most efficient

@maurafortino maurafortino added the needs discussion Further discussion is needed to move forward label Nov 11, 2024
@maurafortino maurafortino self-assigned this Nov 11, 2024
@maurafortino maurafortino marked this pull request as draft November 11, 2024 18:37
@maurafortino maurafortino changed the base branch from main to feat/webhook-update November 11, 2024 18:38
@guardrails GuardRails
Copy link

guardrails bot commented Nov 11, 2024 •
edited
Loading

All previously detected findings have been fixed. Good job! 👍🎉

We will keep this comment up-to-date as you go along and notify you of any security issues that we identify.

👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@maurafortino maurafortino marked this pull request as ready for review November 14, 2024 17:06
denopink
denopink reviewed Nov 15, 2024
View reviewed changes
transport_test.go Outdated Show resolved Hide resolved
denopink
denopink requested changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@denopink denopink left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I only have 2 requested change, otherwise it lgtm! 🍻

denopink
denopink reviewed Nov 15, 2024
View reviewed changes
chrysom/metrics.go Outdated Show resolved Hide resolved
denopink
denopink approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@denopink denopink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw there was a lint/formatting issue, besides that lgtm! 🍻

@maurafortino maurafortino merged commit 710f1a8 into feat/webhook-update Nov 18, 2024
14 checks passed
@maurafortino maurafortino deleted the remove-bascule branch November 18, 2024 15:59
@maurafortino maurafortino mentioned this pull request Nov 25, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denopink denopink denopink approved these changes

Assignees

@maurafortino maurafortino

Labels
needs discussion Further discussion is needed to move forward
Projects
XMiDT
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maurafortino @denopink