-
-
Notifications
You must be signed in to change notification settings - Fork 818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-add cosmocc actions #6083
Re-add cosmocc actions #6083
Conversation
we can test it on macos ci too. https://github.com/xmake-io/xmake/pull/5489/files |
What I meant by "it should work on macos" is that the same binary compiled in linux would also work on macos. |
I know, but we also need to test it to confirm it actually works and isn't just a guess. I ran it on macos ci before and it would get stuck. |
Not for testing compilation, but for testing running, we can only recompile it on macos. Unless we have a way to pass the cosmocc binary built on linux to macos to run. |
I don't know why the comoscc macos actions was cancelled but the same actions on my repo worked (the actions name is different) |
.github/workflows/cosmocc_macos.yml
Outdated
runs-on: ${{ matrix.os }} | ||
|
||
concurrency: | ||
group: ${{ github.ref }}-${{ github.base_ref }}-${{ github.head_ref }}-Cosmocc-${{ matrix.arch }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to set different key for linux/macos.
.github/workflows/cosmocc.yml
Outdated
build: | ||
strategy: | ||
matrix: | ||
os: [ubuntu-latest] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and we can use single yml file.
os: [ubuntu-latest, macos-13]
I successfully built xmake with cosmocc, it runs on linux, so it should work on macos. On Windows there is still the bug in the first comment of issue #6010.
This binary should also work on ARM64 but I cannot test it myself, so if anyone wants to try it out.