Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add cosmocc actions #6083

Merged
merged 9 commits into from
Jan 17, 2025
Merged

Re-add cosmocc actions #6083

merged 9 commits into from
Jan 17, 2025

Conversation

A2va
Copy link
Contributor

@A2va A2va commented Jan 15, 2025

I successfully built xmake with cosmocc, it runs on linux, so it should work on macos. On Windows there is still the bug in the first comment of issue #6010.

This binary should also work on ARM64 but I cannot test it myself, so if anyone wants to try it out.

@waruqi
Copy link
Member

waruqi commented Jan 15, 2025

so it should work on macos

we can test it on macos ci too. https://github.com/xmake-io/xmake/pull/5489/files

@A2va
Copy link
Contributor Author

A2va commented Jan 15, 2025

What I meant by "it should work on macos" is that the same binary compiled in linux would also work on macos.
I don't see to advantages to test the compilation with cosmocc on other platforms

@waruqi
Copy link
Member

waruqi commented Jan 15, 2025

What I meant by "it should work on macos" is that the same binary compiled in linux would also work on macos

I know, but we also need to test it to confirm it actually works and isn't just a guess. I ran it on macos ci before and it would get stuck.

@waruqi
Copy link
Member

waruqi commented Jan 15, 2025

I don't see to advantages to test the compilation with cosmocc on other platforms

Not for testing compilation, but for testing running, we can only recompile it on macos. Unless we have a way to pass the cosmocc binary built on linux to macos to run.

@A2va A2va changed the title Create cosmocc.yml Re-add actions Jan 16, 2025
@A2va
Copy link
Contributor Author

A2va commented Jan 16, 2025

I don't know why the comoscc macos actions was cancelled but the same actions on my repo worked (the actions name is different)
https://github.com/A2va/xmake/actions/runs/12796569514

@A2va A2va changed the title Re-add actions Re-add cosmocc actions Jan 16, 2025
runs-on: ${{ matrix.os }}

concurrency:
group: ${{ github.ref }}-${{ github.base_ref }}-${{ github.head_ref }}-Cosmocc-${{ matrix.arch }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to set different key for linux/macos.

build:
strategy:
matrix:
os: [ubuntu-latest]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and we can use single yml file.

os: [ubuntu-latest, macos-13]

@waruqi waruqi added this to the v2.9.8 milestone Jan 17, 2025
@waruqi waruqi merged commit ce35c1a into xmake-io:dev Jan 17, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants