-
-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libmysofa: add package #6076
libmysofa: add package #6076
Conversation
I don't know you mean, you can try table.insert(configs, "-DBUILD_STATIC_LIBS=" .. (package:config("shared") and "OFF" or "ON"))
table.insert(configs, "-DBUILD_SHARED_LIBS=" .. (package:config("shared") and "ON" or "OFF"))
Yes, We can reference https://archlinux.org/packages/extra/x86_64/libmysofa
C:\PROGRA~1\MICROS~2\2022\COMMUN~1\VC\Tools\MSVC\1442~1.344\bin\Hostx64\x64\cl.exe /nologo -IC:\Users\star\AppData\Local\.xmake\cache\packages\2412\l\libmysofa\v1.3.2\source\build_7ef28615\src -IC:\Users\star\AppData\Local\.xmake\cache\packages\2412\l\libmysofa\v1.3.2\source\windows\third-party\zlib-1.2.11\include -IC:\Users\star\AppData\Local\.xmake\cache\packages\2412\l\libmysofa\v1.3.2\source\src\hrtf /DWIN32 /D_WINDOWS /W3 -Wall /DWIN32 /D_WINDOWS /W3 /Zi /Ob0 /Od /RTC1 -MD -DDEBUG -DVDEBUG /showIncludes /Fosrc\CMakeFiles\mysofa-static.dir\hdf\gcol.c.obj /Fdpdb\ /FS -c C:\Users\star\AppData\Local\.xmake\cache\packages\2412\l\libmysofa\v1.3.2\source\src\hdf\gcol.c Try to patch cmake to use xrepo zlib for unbundle deps. |
We can apply this patch to improve shared library build. |
#endif | ||
|
||
-#if defined(__linux__) || defined(__CYGWIN__) | ||
+#if defined(__linux__) || defined(__CYGWIN__) || defined(__illumos__) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it be there || defined(__EMSCRIPTEN__)
or its better limit wasm build ? https://github.com/hobuinc/laz-perf/blob/2b68700d33bf981d257d6101d96714620c64019c/cpp/lazperf/portable_endian.hpp#L15
maybe || defined(__GNU__)
as well. Though it looks very preferable to just replace existing file with this one.
Well it seems it helped WASM CI for some reason.
If the library documentation says that the platforms (wasm/ios etc...) is supported, but it failed in xrepo ci, we can limit it in xmake-repo/packages/i/igraph/xmake.lua Lines 25 to 31 in 95aa0e9
|
I don't find anything that states out, libmysofa supports wasm/emscripten or not (https://github.com/ColumbiaCEAL/libmysofa-wasm/blob/main/README.md portable endian h not found there). I believe it should pass CI after changing portable endian header, as it is shown in other repo. |
wasm:
Yet it seems emscripten is kind of behaving like different os, it defines unix, unix, EMSCRIPTEN all time, so currently there is either overwrite logic of portable endian h(to support it since it looks like it wont work over emscripten at all) or either doing something like if is_host("linux") then replace(defined(linux), 1)... Or just limit wasm.
feel free to change & merge.
BTW, I dont know if there is need to rename package name from
libmysofa
tomysofa
... I think it is fine it won't affect overfind_package(MySOFA)
at all.