-
-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add libmem #5430
add libmem #5430
Conversation
I did my best to fulfill requests. But now it have to implement keystone port for xrepo, so we could advance further. |
right, we need to add keystone first |
@waruqi Should compile for linux as well now. |
error: @programdir/core/sandbox/modules/os.lua:264: cannot runv(kstool -b x64 "mov rax, 1; ret"), No such file or directory |
We most likely need to exclude IPhoneOS according to on_install("!iphoneos", function (package) Most likely arm/arm64 is not implemented to work for libmem itself. |
fix c++ exports
Hopefully @rdbo would upstream somewhat similiar to this patch since in his cmake build they don't get exported either but seems intended as part of the api. |
we can export symbols automatically. xmake-repo/packages/u/udt/xmake.lua Line 27 in 9c99372
|
error: ...es/private/action/require/impl/actions/patch_sources.lua:100: patch(/home/runner/work/xmake-repo/xmake-repo/packages/l/libmem/patches/cxxexport.patch): unmatched checksum! |
github ci 挂了 不知道为啥 |
github ci is down. I don’t know why. |
https://www.githubstatus.com/ |
Maybe make it more strict only adding Patchdiff --git a/packages/l/libmem/port/xmake.lua b/packages/l/libmem/port/xmake.lua
index b50db9ef..0f80bc20 100644
--- a/packages/l/libmem/port/xmake.lua
+++ b/packages/l/libmem/port/xmake.lua
@@ -8,12 +8,10 @@ target("libmem")
if is_plat("windows") and is_kind("shared") then
add_rules("utils.symbols.export_all", {export_classes = true, export_filter = function (symbol)
- if symbol:find("libmem", 1, true) then
- return true
- end
+ return symbol:find("libmem", 1, true) and true or false
end})
end
- if is_kind("shared") then
+ if is_plat("windows") or is_kind("shared") then
add_defines("LM_EXPORT")
end
diff --git a/packages/l/libmem/xmake.lua b/packages/l/libmem/xmake.lua
index 9e07cdd5..ed80ace1 100644
--- a/packages/l/libmem/xmake.lua
+++ b/packages/l/libmem/xmake.lua
@@ -21,7 +21,7 @@ package("libmem")
end
on_load(function(package)
- if package:config("shared") then
+ if is_plat("windows") or package:config("shared") then
package:add("defines", "LM_EXPORT")
end
end) |
done |
[libmem] add new port