fix parquet-tools cat oom issue #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zolstein
pushed a commit
to zolstein/parquet-go
that referenced
this pull request
Jun 23, 2023
As part of exploring xitongsys#266, it was identified that the code around deserializing Parquet values into Go values should be refactored to make supporting other types like `time.Time` possible. This is the first change which refactors the monolithic `assignValue()` function into an `AssignValue()` function implemented on each Parquet type.
zolstein
pushed a commit
to zolstein/parquet-go
that referenced
this pull request
Jun 23, 2023
To support deserializing Parquet timestamp values for xitongsys#266, there needs to be a way to convert between different Parquet types. For example, there might be a TIMESTAMP(isAdjustedToUTC=true, unit=MILLIS) value stored in a file and it needs to be deserialized into a time.Time which expects a number of nanoseconds. This PR adds a ConvertValue(val Value, typ Type) function to the parquet.Type interface which accepts the source Value and Type and return a Value converted to the Type of the receiver.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.