Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thrift issue in go 1.15 when using parquet-go #319

Closed
ottensjors opened this issue Sep 26, 2020 · 3 comments
Closed

Thrift issue in go 1.15 when using parquet-go #319

ottensjors opened this issue Sep 26, 2020 · 3 comments

Comments

@ottensjors
Copy link

Hi guys,

I’m experiencing the same issue as described in #292

I tried @xitongsys fix that helped out @GordonPman in aforementioned issue. unfortunately this didn’t work and I’m left with same issue.

Set up I’m using:

Ubuntu 20.04 LTS
Go 1.15

Could there be an incompatibility issue between parquet-go and Go 1.15?

The go.mod of parquet-go states “go 1.13”.

Please let me know if I need to. Provide any other info.

Originally posted by @ottensjors in #292 (comment)
@ottensjors ottensjors changed the title Hi guys, Thrift issue in go 1.15 when using parquet-go Sep 26, 2020
@slaskhas
Copy link

In github.com/apache/thrift , notice commit bcae3bb52f976ce245ad77dfb060e5776d67ce85

This is a breaking change that adds context to all Read*, Write*, and
Skip functions to TProtocol, along with the compiler change to support
that, and also adds context to TStandardClient.Recv, TDeserializer,
TStruct, and a few others.

I did a work around (to buy some time) by doing:
cd ~/go/src/github.com/apache/thrift
git checkout 8b8633e8d805905868f359adf85d18326204a5d5
, which is the previous commit.
I was able to build using parquet-go commit from Fri Sep 25 11:51:56 2020 after that in the environment.

go version go1.15.2 linux/amd64
Ubuntu 18.04.5 LTS

@emm777 emm777 mentioned this issue Oct 3, 2020
Closed
@xitongsys
Copy link
Owner

hi, @ottensjors
I have update the pakcage to latest thrift. Please use the latest master branch to test it. THX.

@ottensjors
Copy link
Author

Works like a charm!

Thanks for the quick fix! Much appreciated.

zolstein pushed a commit to zolstein/parquet-go that referenced this issue Jun 23, 2023
@abraithwaite
Refactor Conversion Code to be schema-aware (xitongsys#319)
b03c047 
convert: introduce schema-aware conversions

Prior to this changeset, conversions between rows having different
schemas was not schema aware.  The strategy prior to this PR was simply
to append all the columns sequentially, causing issues when trying to
parse the new row during reconstruction.

Conversion now uses the schema to determine how to build the row, in a
manner which is consistent with what reconstruct expects.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@slaskhas @xitongsys @ottensjors