Merge cockroachdb#80300

80300: kv/bulk: warn instead of fail on failed initial split r=dt a=dt splits can fail for various reasons and it probably isn't worth failing the whole import over. Release note (bug fix): Errors encountered when sending rebalancing hints to the storage layer during IMPORTs and index creation are now only logged and no longer cause the job to fail. Co-authored-by: David Taylor <[email protected]>
xinhaoz · Apr 25, 2022 · 8658bd3 · 8658bd3
2 parents d2eafdf + 11c81be
commit 8658bd3
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/pkg/kv/bulk/buffering_adder.go b/pkg/kv/bulk/buffering_adder.go
@@ -370,9 +370,10 @@ func (b *BufferingAdder) createInitialSplits(ctx context.Context) error {
 			if strings.Contains(err.Error(), "predicate") {
 				log.VEventf(ctx, 1, "%s adder split at %s rejected, had previously split and no longer included %s",
 					b.name, splitKey, predicateKey)
-				continue
+			} else {
+				log.Warningf(ctx, "failed to create initial split %s: %s", splitKey, err)
 			}
-			return err
+			continue
 		}
 		toScatter = append(toScatter, splitKey)
 	}