Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schedule Criteria: weather "clear sky" condition does not match #3487

Closed
dasgarner opened this issue Aug 28, 2024 · 0 comments
Closed

Schedule Criteria: weather "clear sky" condition does not match #3487

dasgarner opened this issue Aug 28, 2024 · 0 comments
Assignees
Labels
Milestone

Comments

@dasgarner
Copy link
Member

In the criteria it is clear_sky and in the weather data provided to XMDS it is clear. It looks like we've missed mapping the return from OWM to our conditions.

@dasgarner dasgarner added this to the 4.1.1 milestone Aug 28, 2024
@dasgarner dasgarner added the bug label Aug 28, 2024
nadzpogi added a commit to xibosignage/xibo-cms that referenced this issue Sep 18, 2024
relates to xibosignage/xibo#3487

- Modified metric IDs to better align with JSON responses from the OWM API.
- Added a prefix to avoid conflicts with other potential weather schedule criteria.
- Removed metrics that are not present in OpenWeather API responses.
nadzpogi added a commit to xibosignage/xibo-cms that referenced this issue Sep 19, 2024
relates to xibosignage/xibo#3487

- Added a prefix to the weather XMDS response.
- Restored Wind Direction with fewer options after it was previously removed.
nadzpogi added a commit to xibosignage/xibo-cms that referenced this issue Sep 20, 2024
nadzpogi added a commit to xibosignage/xibo-cms that referenced this issue Oct 1, 2024
relates to xibosignage/xibo#3487

- Updated the weather schedule criteria's and XMDS getWeather's prefix.
nadzpogi added a commit to xibosignage/xibo-cms that referenced this issue Oct 2, 2024
relates to xibosignage/xibo#3487

- Fixed the formatting of weather condition values.
- Set the `type` criteria as the prefix for the metric's value
nadzpogi added a commit to xibosignage/xibo-cms that referenced this issue Oct 2, 2024
@nadzpogi nadzpogi closed this as completed Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants