Skip to content

Commit

Permalink
fix grafana CrashLoopBackoff on image 5.0.3
Browse files Browse the repository at this point in the history
this is a known issue with grafana in k8s. `grafana/grafana:5.0.4` was just released today. update the repo from `5.0.3` to `5.0.4`
fixed issues linkerd#582

Signed-off-by: Deshi Xiao <[email protected]>
  • Loading branch information
xiaods committed Mar 29, 2018
1 parent 67fac9d commit 5c00911
Show file tree
Hide file tree
Showing 8 changed files with 10 additions and 8 deletions.
4 changes: 3 additions & 1 deletion Dockerfile-go-deps
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,11 @@ RUN GOPATH=${TEMP_GOPATH} bin/dep version
# because it needs all our source files, which are not available here.
COPY Gopkg.toml Gopkg.lock ./
RUN \
export http_proxy=http://192.168.1.5:1235; export https_proxy=$http_proxy; echo 'HTTP Proxy on'; \
GOPATH=${TEMP_GOPATH} bin/dep ensure -vendor-only -v && \
mv vendor/* /go/src/ && \
rm -rf ${TEMP_GOPATH}
rm -rf ${TEMP_GOPATH} \
unset http_proxy; unset https_proxy; echo 'HTTP Proxy off';

# The previous WORKDIR was deleted. Reset it to avoid any potential for
# strangeness later.
Expand Down
2 changes: 1 addition & 1 deletion cli/Dockerfile-bin
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
## compile binaries
FROM gcr.io/runconduit/go-deps:cc2413fa as golang
FROM gcr.io/runconduit/go-deps:e5ad921e as golang
ARG CONDUIT_VERSION
WORKDIR /go/src/github.com/runconduit/conduit
COPY cli cli
Expand Down
2 changes: 1 addition & 1 deletion cli/cmd/install.go
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ func validateAndBuildConfig() (*installConfig, error) {
ControllerImage: fmt.Sprintf("%s/controller:%s", dockerRegistry, conduitVersion),
WebImage: fmt.Sprintf("%s/web:%s", dockerRegistry, conduitVersion),
PrometheusImage: "prom/prometheus:v2.1.0",
GrafanaImage: "grafana/grafana:5.0.3",
GrafanaImage: "grafana/grafana:5.0.4",
// TODO: these dashboards assume we're running in the "conduit" namespace
VizDashboard: install.Viz,
DeploymentDashboard: install.Deployment,
Expand Down
2 changes: 1 addition & 1 deletion cli/cmd/testdata/install_default.golden
Original file line number Diff line number Diff line change
Expand Up @@ -633,7 +633,7 @@ spec:
conduit.io/proxy-deployment: grafana
spec:
containers:
- image: grafana/grafana:5.0.3
- image: grafana/grafana:5.0.4
imagePullPolicy: IfNotPresent
name: grafana
ports:
Expand Down
2 changes: 1 addition & 1 deletion controller/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
## compile controller services
FROM gcr.io/runconduit/go-deps:cc2413fa as golang
FROM gcr.io/runconduit/go-deps:e5ad921e as golang
ARG CONDUIT_VERSION
WORKDIR /go/src/github.com/runconduit/conduit
COPY controller/gen controller/gen
Expand Down
2 changes: 1 addition & 1 deletion docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ services:
- --storage.tsdb.retention=6h

grafana:
image: grafana/grafana:5.0.3
image: grafana/grafana:5.0.4
ports:
- 3000:3000
volumes:
Expand Down
2 changes: 1 addition & 1 deletion proxy-init/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
## compile proxy-init utility
FROM gcr.io/runconduit/go-deps:cc2413fa as golang
FROM gcr.io/runconduit/go-deps:e5ad921e as golang
WORKDIR /go/src/github.com/runconduit/conduit
COPY ./proxy-init ./proxy-init
RUN CGO_ENABLED=0 GOOS=linux go install -v -installsuffix cgo ./proxy-init/
Expand Down
2 changes: 1 addition & 1 deletion web/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ RUN $HOME/.yarn/bin/yarn install --pure-lockfile
RUN $HOME/.yarn/bin/yarn webpack

## compile go server
FROM gcr.io/runconduit/go-deps:cc2413fa as golang
FROM gcr.io/runconduit/go-deps:e5ad921e as golang
ARG CONDUIT_VERSION
WORKDIR /go/src/github.com/runconduit/conduit
COPY web web
Expand Down

0 comments on commit 5c00911

Please sign in to comment.